Structure improvements #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the project structure by reorganizing test setup files, updating configuration files, and making code quality improvements. The changes modernize the testing infrastructure and improve maintainability.
- Moved test setup files into a
test/helpers/directory for better organization - Updated ESLint configuration to use flat config format and target only source files
- Refactored package.json to use peer dependencies instead of direct dependencies and updated npm scripts
- Made minor code style improvements (quote consistency, semicolon placement)
- Dropped Node.js 18.x support, now requiring Node 20.x or 22.x
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/sourcePane.test.js | Updated import path to reference relocated setup file in helpers directory |
| test/helpers/setup.js | New test setup file with context exports (missing some expected exports) |
| test/helpers/jest.setup.js | New Jest setup configuration for test environment initialization |
| src/sourcePane.js | Minor code style fixes (quote consistency) and addition of unused pos variable |
| package.json | Restructured dependencies, updated scripts, and added files field for npm publishing |
| jest.config.js | Updated setup file path and added test coverage configuration |
| eslint.config.mjs | Migrated to flat config format with updated rules and file targeting |
| .github/workflows/ci.yml | Removed Node.js 18.x from test matrix |
Comments suppressed due to low confidence (3)
test/sourcePane.test.js:1
- The imported
docandsubjectvariables are not exported from './helpers/setup'. Onlycontextis exported. This will cause a runtime error when the test runs.
test/sourcePane.test.js:1 - Unused variable doc.
test/sourcePane.test.js:1 - Unused variable subject.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the optimization work.
Drop node 18